Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the unused multicolors dependency from the SourceKnight build configuration and updates the plugin to no longer include or use MultiColors-based chat printing, keeping the plugin build and runtime surface area minimal.
Changes:
- Removed the
multicolorsdependency fromsourceknight.yaml. - Removed
#include <multicolors>from the plugin and replacedCPrintToChatusage withPrintToChat. - Bumped plugin version from
3.2.3to3.2.4.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
sourceknight.yaml |
Drops the now-unneeded multicolors dependency from the build dependency list. |
addons/sourcemod/scripting/VIP_SourcemodFlags.sp |
Removes the MultiColors include and switches remaining chat output to stock PrintToChat; increments plugin version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.